dstandish commented on a change in pull request #19339:
URL: https://github.com/apache/airflow/pull/19339#discussion_r740367760
##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -21,22 +21,22 @@
Kubernetes Executor
===================
-The kubernetes executor is introduced in Apache Airflow 1.10.0. The Kubernetes
executor will create a new pod for every task instance.
+The Kubernetes executor runs each task instance in its own pod on a Kubernetes
cluster.
-Example kubernetes files are available at
``scripts/in_container/kubernetes/app/{secrets,volumes,postgres}.yaml`` in the
source distribution (please note that these examples are not ideal for
production environments).
-The volumes are optional and depend on your configuration. There are two
volumes available:
+Use of persistent volumes is optional and depends on your configuration. There
are two types of volumes you may configure:
- **Dags**:
- - By storing dags onto persistent disk, it will be made available to all
workers
+ - By storing dags on a persistent volume, it will be made available to all
workers
Review comment:
> Totally possible to have a PV that is populated by CICD
Good point.
> That said, this whole section until pod_template_file feels a little out
of place to me for KubenetesExecutor docs 🤷♂️.
I agree -- this kind of subject seems to make more sense in helm chart. I
can do another pass through with this in mind, and try to focus it just on the
executor and if we need to point to helm chart docs where it gets more into
implementation -- LMKYT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
