dstandish commented on a change in pull request #19339:
URL: https://github.com/apache/airflow/pull/19339#discussion_r741403673
##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -21,22 +21,22 @@
Kubernetes Executor
===================
-The kubernetes executor is introduced in Apache Airflow 1.10.0. The Kubernetes
executor will create a new pod for every task instance.
+The Kubernetes executor runs each task instance in its own pod on a Kubernetes
cluster.
-Example kubernetes files are available at
``scripts/in_container/kubernetes/app/{secrets,volumes,postgres}.yaml`` in the
source distribution (please note that these examples are not ideal for
production environments).
-The volumes are optional and depend on your configuration. There are two
volumes available:
+Use of persistent volumes is optional and depends on your configuration. There
are two types of volumes you may configure:
- **Dags**:
- - By storing dags onto persistent disk, it will be made available to all
workers
+ - By storing dags on a persistent volume, it will be made available to all
workers
Review comment:
OK so, after some reflection, one thought on this section.
Users don't need to use our helm chart, nor do they even need to be running
airflow on k8s, in order to use k8s executor. They just need access to a
cluster. E.g. you could have scheduler and webserver running on ECS, and send
your pods to an eks cluster you have access to.
So with that in mind, looking only at k8s executor, it doesn't seem
unreasonable to keep this brief section on how to manage dags and logs.
##########
File path: docs/apache-airflow/executor/kubernetes.rst
##########
@@ -21,22 +21,22 @@
Kubernetes Executor
===================
-The kubernetes executor is introduced in Apache Airflow 1.10.0. The Kubernetes
executor will create a new pod for every task instance.
+The Kubernetes executor runs each task instance in its own pod on a Kubernetes
cluster.
-Example kubernetes files are available at
``scripts/in_container/kubernetes/app/{secrets,volumes,postgres}.yaml`` in the
source distribution (please note that these examples are not ideal for
production environments).
-The volumes are optional and depend on your configuration. There are two
volumes available:
+Use of persistent volumes is optional and depends on your configuration. There
are two types of volumes you may configure:
- **Dags**:
- - By storing dags onto persistent disk, it will be made available to all
workers
+ - By storing dags on a persistent volume, it will be made available to all
workers
Review comment:
sure -- just reorganized, ptal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
