jedcunningham commented on a change in pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#discussion_r741267980
##########
File path: chart/values.schema.json
##########
@@ -568,6 +601,23 @@
"type": "array",
"x-docsSection": "Airflow",
"default": [],
+ "items": {
+ "type": "object",
+ "properties": {
+ "envName": {
+ "description": "The name of the environment variable
under which the secret will be available",
+ "type": "string"
+ },
+ "secretName": {
+ "description": "The name of the Kubernetes secret that
will be read",
+ "type": "string"
+ },
+ "secretKey": {
+ "description": "The key of the Kubernetes secret",
+ "type": "string"
+ }
+ }
Review comment:
```suggestion
},
"additionalProperties": False,
"required": ["envName", "secretName"]
```
##########
File path: chart/values.schema.json
##########
@@ -89,13 +89,18 @@
"description": "Specify scheduling constraints for all pods.",
"type": "object",
"default": {},
- "x-docsSection": "Kubernetes"
+ "x-docsSection": "Kubernetes",
+ "$ref":
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0/_definitions.json#/definitions/io.k8s.api.core.v1.Affinity";
},
"tolerations": {
"description": "Specify Tolerations for all pods.",
"type": "array",
"default": [],
- "x-docsSection": "Kubernetes"
+ "x-docsSection": "Kubernetes",
+ "items": {
+ "type": "object",
+ "$ref":
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0/_definitions.json#/definitions/io.k8s.api.core.v1.Toleration";
Review comment:
Thoughts on using the strict variant? e.g:
https://github.com/yannh/kubernetes-json-schema/blob/master/v1.22.0-standalone-strict/_definitions.json
We are strict by default in our schema, I think it makes sense to continue
that trend here too.
##########
File path: chart/values.schema.json
##########
@@ -89,13 +89,18 @@
"description": "Specify scheduling constraints for all pods.",
"type": "object",
"default": {},
- "x-docsSection": "Kubernetes"
+ "x-docsSection": "Kubernetes",
+ "$ref":
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0/_definitions.json#/definitions/io.k8s.api.core.v1.Affinity";
},
"tolerations": {
"description": "Specify Tolerations for all pods.",
"type": "array",
"default": [],
- "x-docsSection": "Kubernetes"
+ "x-docsSection": "Kubernetes",
+ "items": {
+ "type": "object",
+ "$ref":
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0/_definitions.json#/definitions/io.k8s.api.core.v1.Toleration";
Review comment:
Is there a benefit to using the full `_definitions.json` over using
specific schemas? e.g:
https://github.com/yannh/kubernetes-json-schema/blob/master/v1.22.0-standalone-strict/toleration-v1.json
##########
File path: chart/values.schema.json
##########
@@ -2069,11 +2258,38 @@
"annotations": {
"description": "Annotations for the webserver
Service.",
"type": "object",
- "default": {}
+ "default": {},
+ "additionalProperties": {
+ "type": "string"
+ }
},
"ports": {
"description": "Ports for the webserver Service.",
"type": "array",
+ "items": {
+ "type": "object",
+ "additionalProperties": false,
+ "properties": {
+ "name": {
+ "type": "string"
+ },
+ "port": {
+ "type": [
+ "string",
+ "integer"
+ ]
+ },
+ "targetPort": {
+ "type": [
+ "string",
+ "integer"
+ ]
+ },
+ "protocol": {
+ "type": "string"
+ }
+ }
+ },
Review comment:
We should be able to use `ServicePort` here (and with flower), no?
```suggestion
"items": {
"$ref":
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0/_definitions.json#/definitions/io.k8s.api.core.v1.ServicePort";
},
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
