mik-laj commented on a change in pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#discussion_r741626451
##########
File path: chart/values.schema.json
##########
@@ -89,13 +89,18 @@
"description": "Specify scheduling constraints for all pods.",
"type": "object",
"default": {},
- "x-docsSection": "Kubernetes"
+ "x-docsSection": "Kubernetes",
+ "$ref":
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0/_definitions.json#/definitions/io.k8s.api.core.v1.Affinity";
},
"tolerations": {
"description": "Specify Tolerations for all pods.",
"type": "array",
"default": [],
- "x-docsSection": "Kubernetes"
+ "x-docsSection": "Kubernetes",
+ "items": {
+ "type": "object",
+ "$ref":
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0/_definitions.json#/definitions/io.k8s.api.core.v1.Toleration";
Review comment:
I checked, and we use a very narrow subset of object types, so it's
better to fetch each definition separately.
```
cat chart/values.schema.json | jq '.. | objects| .["$ref"] | strings' | sort
| uniq
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.apps.v1.DeploymentStrategy";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.core.v1.Affinity";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.core.v1.Container";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.core.v1.HostAlias";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.core.v1.LimitRangeItem";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.core.v1.ResourceRequirements";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.core.v1.Toleration";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.core.v1.Volume";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.core.v1.VolumeMount";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.networking.v1.NetworkPolicyPeer";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.api.networking.v1.NetworkPolicyPort";
"https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.22.0-standalone-strict/_definitions.json#/definitions/io.k8s.apimachinery.pkg.api.resource.Quantity";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
