mik-laj commented on a change in pull request #19181:
URL: https://github.com/apache/airflow/pull/19181#discussion_r742133261
##########
File path: chart/tests/test_flower.py
##########
@@ -358,18 +358,18 @@ def test_defaults(self):
"ports, expected_ports",
[
(
- [{"name": "{{ .Release.Name }}", "protocol": "UDP", "port":
"{{ .Values.ports.flowerUI }}"}],
- [{"name": "RELEASE-NAME", "protocol": "UDP", "port": 5555}],
+ [{"protocol": "UDP", "port": "{{ .Values.ports.flowerUI }}"}],
+ [{"protocol": "UDP", "port": 5555}],
),
- ([{"name": "only_sidecar", "port": "sidecar"}], [{"name":
"only_sidecar", "port": "sidecar"}]),
+ ([{"port": "sidecar"}], [{"port": "sidecar"}]),
(
[
- {"name": "flower-ui", "port": "{{ .Values.ports.flowerUI
}}"},
- {"name": "sidecar", "port": 80},
+ {"port": "{{ .Values.ports.flowerUI }}"},
+ {"port": 80},
Review comment:
This is a test for NetworkPolicy, not Service. In NetworkPolicy, we use
[NetworkPolicyPort](https://github.com/yannh/kubernetes-json-schema/blob/master/v1.21.0/serviceport-v1.json),
not
[ServicePort](https://github.com/yannh/kubernetes-json-schema/blob/master/v1.21.0/serviceport-v1.json),
so `name` field is illegal here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
