kaxil commented on a change in pull request #19367:
URL: https://github.com/apache/airflow/pull/19367#discussion_r742361388
##########
File path: airflow/models/dag.py
##########
@@ -2880,12 +2883,16 @@ def dags_needing_dagruns(cls, session: Session):
# TODO[HA]: Bake this query, it is run _A lot_
# We limit so that _one_ scheduler doesn't try to do all the creation
# of dag runs
+ # exclude dags with import error
+ import_errors = [c.filename for c in
session.query(importerror.filename).all()]
Review comment:
Can you test this with zip file too please
##########
File path: airflow/models/dag.py
##########
@@ -2880,12 +2883,16 @@ def dags_needing_dagruns(cls, session: Session):
# TODO[HA]: Bake this query, it is run _A lot_
# We limit so that _one_ scheduler doesn't try to do all the creation
# of dag runs
+ # exclude dags with import error
+ import_errors = [c.filename for c in
session.query(importerror.filename).all()]
Review comment:
Can you test this with zip file too please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
