jedcunningham commented on a change in pull request #19367:
URL: https://github.com/apache/airflow/pull/19367#discussion_r742143431
##########
File path: airflow/models/dag.py
##########
@@ -2743,7 +2743,9 @@ def __init__(self, concurrency=None, **kwargs):
else:
self.max_active_tasks = conf.getint('core',
'max_active_tasks_per_dag')
if self.max_active_runs is None:
- self.max_active_runs = conf.getint('core',
'max_active_runs_per_dag')
+ self.max_active_runs = kwargs.get(
+ 'max_active_runs', conf.getint('core',
'max_active_runs_per_dag', fallback=16)
+ )
Review comment:
Wait, why do we need the fallback? It should get it from the default
config anyways.
##########
File path: airflow/models/dag.py
##########
@@ -2743,7 +2743,9 @@ def __init__(self, concurrency=None, **kwargs):
else:
self.max_active_tasks = conf.getint('core',
'max_active_tasks_per_dag')
if self.max_active_runs is None:
- self.max_active_runs = conf.getint('core',
'max_active_runs_per_dag')
+ self.max_active_runs = kwargs.get(
+ 'max_active_runs', conf.getint('core',
'max_active_runs_per_dag', fallback=16)
+ )
Review comment:
Gotcha. They'd have to remove it from the
`config_templates/default_airflow.cfg` in their install, so I think that is
unlikely to be the cause.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
