bugraoz93 commented on a change in pull request #19377:
URL: https://github.com/apache/airflow/pull/19377#discussion_r744343709
##########
File path: airflow/providers/facebook/ads/hooks/ads.py
##########
@@ -119,25 +120,30 @@ def bulk_facebook_report(
:type sleep_time: int
:return: Facebook Ads API response, converted to Facebook Ads Row
objects
- :rtype: List[AdsInsights]
+ :rtype: Dict[str, List[AdsInsights]]
Review comment:
Hi @potiuk, I have not thought that way. For sure, I could easily
support that with a simple implementation. Since this hook is only used by
FacebookAdsReportToGcsOperator, I thought that while I am changing the return
type of the hook only affects this operator. For that reason, since I have
changed that operator, I thought the return type could be a single type and not
affect anywhere else. I will make that change to provide backward compatibility
as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
