bugraoz93 commented on a change in pull request #19377:
URL: https://github.com/apache/airflow/pull/19377#discussion_r744543108
##########
File path: airflow/providers/facebook/ads/hooks/ads.py
##########
@@ -119,25 +120,30 @@ def bulk_facebook_report(
:type sleep_time: int
:return: Facebook Ads API response, converted to Facebook Ads Row
objects
- :rtype: List[AdsInsights]
+ :rtype: Dict[str, List[AdsInsights]]
Review comment:
You are right. Your comment about returning two different data
structures made me realize some of these outcomes and these use cases. I was
thinking of a platform that uses operators to run a certain task, in the end,
it is not just a tool (It is also a set of useful decoupled tools and
libraries). Also, we are using some of those hooks in our stack. From now on, I
will be more careful about backward compatibility even if that means a method
return two different data structure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
