josh-fell commented on a change in pull request #19497:
URL: https://github.com/apache/airflow/pull/19497#discussion_r746728905
##########
File path: airflow/utils/log/secrets_masker.py
##########
@@ -34,6 +34,7 @@
DEFAULT_SENSITIVE_FIELDS = frozenset(
{
'access_token',
+ 'access_key',
Review comment:
Yep, fair point. Although when the AWS Access Key is written to the logs
I imagine it's not masked since its specified as `login` in the connection.
Only if the access key is added to `Extras` is the value masked (although the
[connection
doc](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/connections/aws.html)
for AWS doesn't specify using `Extras` in this manner) -- seems unlikely this
approach is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
