ephraimbuddy commented on a change in pull request #19528:
URL: https://github.com/apache/airflow/pull/19528#discussion_r746957754
##########
File path: airflow/jobs/scheduler_job.py
##########
@@ -913,7 +913,8 @@ def _create_dag_runs(self, dag_models:
Collection[DagModel], session: Session) -
creating_job_id=self.id,
)
active_runs_of_dags[dag.dag_id] += 1
- self._update_dag_next_dagruns(dag, dag_model,
active_runs_of_dags[dag.dag_id])
+ if self._update_dag_next_dagruns(dag, dag_model,
active_runs_of_dags[dag.dag_id]):
+ dag_model.calculate_dagrun_date_fields(dag, data_interval)
Review comment:
I will go with renaming cause calling `calculate_dagrun_date_fields`
only won't handle the `max_active_runs` for the dag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
