kaxil commented on a change in pull request #19528:
URL: https://github.com/apache/airflow/pull/19528#discussion_r746975591
##########
File path: airflow/models/dag.py
##########
@@ -630,6 +630,7 @@ def get_next_data_interval(self, dag_model: "DagModel") ->
Optional[DataInterval
data_interval = dag_model.next_dagrun_data_interval
if data_interval is not None:
return data_interval
+ self.log.warning("%s needed to infer interval", self.dag_id)
Review comment:
The message does not make sense.
"'example_bash_operator' needed to infer interval"
```suggestion
```
##########
File path: tests/jobs/test_scheduler_job.py
##########
@@ -2874,6 +2875,66 @@ def
test_more_runs_are_not_created_when_max_active_runs_is_reached(self, dag_mak
== 0
)
+ def test_max_active_runs_creation_phasing(self, dag_maker, session):
+ """
+ Test that when creating runs once max_active_runs is reached that the
dags come in the right order
+ without gaps
+ """
+
+ def complete_one_dagrun():
+ ti = (
+ session.query(TaskInstance)
+ .join(TaskInstance.dag_run)
+ .filter(TaskInstance.state != State.SUCCESS)
+ .order_by(DagRun.execution_date)
+ .first()
+ )
+ if ti:
+ ti.state = State.SUCCESS
+ session.flush()
+
+ with dag_maker(max_active_runs=3, session=session) as dag:
+ # Need to use something that doesn't immediately get marked as
success by the scheduler
+ BashOperator(task_id='task', bash_command='true')
+
+ self.scheduler_job = SchedulerJob(subdir=os.devnull)
+ self.scheduler_job.executor = MockExecutor(do_update=True)
+ self.scheduler_job.processor_agent =
mock.MagicMock(spec=DagFileProcessorAgent)
+
+ DagModel.dags_needing_dagruns(session).all()
+ for _ in range(3):
+ self.scheduler_job._do_scheduling(session)
+
+ model: DagModel = session.query(DagModel).get(dag.dag_id)
+
+ # Pre-condition
+ assert DagRun.active_runs_of_dags(session=session) == {'test_dag': 3}
+
+ assert model.next_dagrun == timezone.convert_to_utc(
+ timezone.DateTime(
+ 2016,
+ 1,
+ 3,
+ )
+ )
+ assert model.next_dagrun_create_after is None
+
+ complete_one_dagrun()
+
+ assert DagRun.active_runs_of_dags(session=session) == {'test_dag': 3},
"Test only. XXX Remove me"
Review comment:
@ephraimbuddy ^^
##########
File path: airflow/models/dag.py
##########
@@ -630,6 +630,7 @@ def get_next_data_interval(self, dag_model: "DagModel") ->
Optional[DataInterval
data_interval = dag_model.next_dagrun_data_interval
if data_interval is not None:
return data_interval
+ self.log.warning("%s needed to infer interval", self.dag_id)
Review comment:
If however, we want to add it, we probably add it in
`infer_automated_data_interval`, something like:
"Inferring Data Interval for self.dag_id"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
