alexbegg commented on a change in pull request #19530:
URL: https://github.com/apache/airflow/pull/19530#discussion_r747228591
##########
File path: tests/providers/salesforce/hooks/test_salesforce.py
##########
@@ -48,8 +49,41 @@ def test_get_conn_exists(self):
assert self.salesforce_hook.conn.return_value is not None
+ @parameterized.expand(
+ [
+ (
+ "all extras",
+ '''
+ {
+ "extra__salesforce__client_id": "my_client",
+ "extra__salesforce__consumer_key": "",
+ "extra__salesforce__domain": "test",
+ "extra__salesforce__instance": "",
+ "extra__salesforce__instance_url": "",
+ "extra__salesforce__organization_id": "",
+ "extra__salesforce__private_key": "",
+ "extra__salesforce__private_key_file_path": "",
+ "extra__salesforce__proxies": "",
+ "extra__salesforce__security_token": "token",
+ "extra__salesforce__version": "42.0"
+ }
+ ''',
+ ),
+ (
+ "required extras",
+ '''
+ {
+ "extra__salesforce__client_id": "my_client",
+ "extra__salesforce__domain": "test",
+ "extra__salesforce__security_token": "token",
+ "extra__salesforce__version": "42.0"
+ }
+ ''',
+ ),
+ ]
Review comment:
I agree. That sounds good actually. A lot less lines of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
