potiuk commented on issue #14396: URL: https://github.com/apache/airflow/issues/14396#issuecomment-966088200
> @potiuk Extracting a Context class out into a new module was my initial thought, but it looked like you were arguing pretty hard _for_ the TypedDict solution. A new `airflow.models.context` module won't be a trivial change and I want to make sure we're "all" on the same page before wasting a ton of time on something that will get shot down based on the implementation. I just got more on the front of "what we want to get from it" rather than "how to implement it" (maybe I grew up a bit since the last time we discussed and look at it more from a "product" point of view rather than implementation detail. I am not sure if TypedDict will be enough to support all the use cases above - but since it's about the time you are implementing it, it might be worth looking at alternatives - because maybe different aproach will yeild more natural use by the users. I think we are changing it now precisely because we wan to make it easier for the users of "context" to get more natural experience and simply have it easier to use. So whatever solution we come up with - it's just the question of how benefital it will be for the users. I am not against or for TypedDict or separate class - I just think that when we are touching it - we should see whether we can make it easier to use in those cases I listed above :). Let's just think about those cases and see how the solution we come up fits-in and which of the cases it supports.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
