mik-laj commented on a change in pull request #19518:
URL: https://github.com/apache/airflow/pull/19518#discussion_r750337704
##########
File path: airflow/providers/google/cloud/operators/kubernetes_engine.py
##########
@@ -350,6 +361,22 @@ def execute(self, context) -> Optional[str]:
"--project",
self.project_id,
]
+ if self.impersonation_chain:
+ if isinstance(self.impersonation_chain, str):
+ impersonation_chain = self.impersonation_chain
Review comment:
This variable name is confusing. The chain suggests it will be. multiple
accounts, but you have one account. This variable (`impersonation_chain`) can
also be confused with the `self.impersonation_chain` field. What do you think
to rename it to ``impersonation_account``?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
