mik-laj commented on a change in pull request #19518:
URL: https://github.com/apache/airflow/pull/19518#discussion_r752049070



##########
File path: airflow/providers/google/cloud/operators/kubernetes_engine.py
##########
@@ -350,6 +361,22 @@ def execute(self, context) -> Optional[str]:
                 "--project",
                 self.project_id,
             ]
+            if self.impersonation_chain:
+                if isinstance(self.impersonation_chain, str):
+                    impersonation_chain = self.impersonation_chain

Review comment:
       The previous use of the impersonation chain looked fine for me. I just 
had my doubts about the name of the local variable. A local variable has never 
stored multiple accounts, but always only one account.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to