dstandish commented on a change in pull request #19662:
URL: https://github.com/apache/airflow/pull/19662#discussion_r752655282
##########
File path: airflow/models/baseoperator.py
##########
@@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None):
if self._post_execute_hook is not None:
self._post_execute_hook(context, result)
- def on_kill(self) -> None:
Review comment:
hmm well, it's also confusing to have both `on_terminate` and
`on_kill`... signature evolution is a thing that happens... seems preferable
to me to evolve it in place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
