dstandish commented on a change in pull request #19662:
URL: https://github.com/apache/airflow/pull/19662#discussion_r753577455



##########
File path: airflow/models/baseoperator.py
##########
@@ -1000,7 +1000,7 @@ def post_execute(self, context: Any, result: Any = None):
         if self._post_execute_hook is not None:
             self._post_execute_hook(context, result)
 
-    def on_kill(self) -> None:

Review comment:
       another way we could accomplish the same thing is if there were a 
reliable way to store state.  e.g.  if we could store pod details, then as soon 
as we have the pod info we could store it with `self.state.set('pod')` or 
similar.  Then within `on_kill` could retrieve this with 
`self.state.get('pod')` or similar




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to