dstandish commented on a change in pull request #19505:
URL: https://github.com/apache/airflow/pull/19505#discussion_r757081246
##########
File path: airflow/models/xcom.py
##########
@@ -364,6 +372,12 @@ def orm_deserialize_value(self) -> Any:
return BaseXCom.deserialize_value(self)
+def serialize_value_shim(**kwargs):
+ signature = inspect_function_arguments(XCom.serialize_value)
+ kwargs = {k: v for k, v in kwargs.items() if k in
signature.bound_arguments}
+ return XCom.serialize_value(**kwargs)
Review comment:
> Worth a docstring explaining why this is needed.
yeah true i have explanation in test i can move or copy here
> Also I wonder if it’d be a good idea to emit a warning telling the XCom
backend to upgrade to the new arguments.
yeah if we're going deprecation route that makes sense
also, i've been very permissive here allowing any combination of kwargs ---
do you think i should stick with that or just allow 2 options: (1) value only
and (2) all params in `set`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
