fredthomsen commented on pull request #18542: URL: https://github.com/apache/airflow/pull/18542#issuecomment-979683371
> i'm in support of this change (and thanks, and nice work) > > but may have found an issue with backward compatibility that should be addressed (see review comments) > > also, following up on our previous discussion, i think that ultimately we should add per-host path here too. i was chatting with someone on slack and realized what path is actually for and it's apparently the path after hostname not the path on the service (i think) in which case yeah it's def conceivable that for diff hosts you might want diff paths. > > BUT that definitely doesn't need to scope-creep its way into this PR just saying for future > > thanks (and i'll try and hit the next iterations more speedily) You are correct, it is the path in the url, so adding this would give you the ability to hit airflow from a different path on different hosts, and I am happy to tackle that next if we want that sooner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
