dstandish commented on a change in pull request #18542:
URL: https://github.com/apache/airflow/pull/18542#discussion_r757228791
##########
File path: chart/templates/webserver/webserver-ingress.yaml
##########
@@ -39,12 +39,27 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
- {{- if .Values.ingress.web.tls.enabled }}
+ {{- if and .Values.ingress.web.hosts (.Values.ingress.web.hosts | first |
kindIs "string" | not) }}
+ {{- $anyTlsHosts := false -}}
+ {{- range .Values.ingress.web.hosts }}
+ {{- if .tls.enabled }}
Review comment:
I assumed this change was supposed to be backwards compatible, so that
list[str] should be deprecated but still work.
It's possible to break things in a major release though, and @jedcunningham
mentioned possibly doing that sooner than later and cleaning up some
backcompat. @jedcunningham should we keep backward compatibility in this one
or just target next major?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
