dstandish commented on pull request #19857:
URL: https://github.com/apache/airflow/pull/19857#issuecomment-980830665


   >  Maybe we should apply the approach of AWS for all other backends? Maybe 
we can find a similar, generic-enough solution for all of them. **I think your 
proposal is attempt to do so, but I think (see below) it might be that it looks 
at the problem from a wrong angle.**
   
   That is not what I'm attempting to do here.  JSON is simply a better, 
friendlier way to store creds than URI.  And the cat is out of the bag with 
allowing JSON storage of connections.  So, I think we should embrace it and 
allow it uniformly.
   
   What's the alternative?  Do you think we should disallow entirely the use of 
json as secrets serialization format?  Or perhaps allow it on a case-by-case 
basis?  Or, perhaps for every backend we should make a json version such e.g. 
EnvironmentVariablesJSONBackend and SystemManagerParameterStoreJSONBackend etc?
   
   Separately, I do recognize that having one place to store creds retrievable 
from many systems can be nice.  Using JSON can actually help in this regard.  
I've actually done this where jupyter and airflow pulled from same creds in aws 
systems manager.  But that's not the problem I'm trying to solve in this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to