potiuk commented on pull request #19857: URL: https://github.com/apache/airflow/pull/19857#issuecomment-981061859
Sure - don't get me wrong. I do see the incrememental improvement of using json, and I am not at all against it, I just think that it does not solve "real" (and different) problem of some organisations which might want to keep secrets in their own structure rather than following Airflow ways. It was not my intention to block it or contest it - it was more to raise attention to the fact that it might not be solving a more 'painful" issue for our users. Which is perfectly fine - it does not have to. It solves other issues and I agree it is an improvement over the current URI form. However I do think there is not a lot we should do now about the bigger (IMHO) issue (unless someone wants to take on the task on trying to generalize the approach that is implemented in AWS secret backend). And It's good we had this discussion because I had a chance to write down my thoughts about it and realise that what we really need to do is to add a little chapter to simply describe the status-quo and guide the users who have this kind of problem to roll their own backends (which I proposed in #19859) For now this is I think perfectly fine to keep it this way (and I'd love to hear other's comments on the "json format" as well). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
