potiuk edited a comment on pull request #19867:
URL: https://github.com/apache/airflow/pull/19867#issuecomment-981693655


   > Note that `execv` does not work on Windows, so that’d be a problem if 
we’re moving toward supporting Windows.
   
   This is not what the documentation tells:  
https://docs.python.org/3/library/os.html#os.execv
   
   | Availability: Unix, Windows.
   
   I think we'd have to check whether to add `.exe` or not (but I think it 
should work without). But I see no reason why it would not work.
   
   > You mention pipx earlier, and I feel it might be a better setup for 
contributors? Just `pipx install apache-airflow-breeze` and run `breeze` in the 
repository root. This is also more friendly to Windows since pipx (actually 
pip) would automatically create an exe for the command.
   
   What I really want, is to be able to run Breeze with all the latest 
modifications included so I really want the workflow:
   
   1) `git checkout main && git pull`
   2) `./Breeze2` (or `python Breeze2` for Windows) -> run all latest and 
greates Breeze. I do not want any "install" command between those two. 
   
   What's even more, I want to be able to switch to another branch and do:
   
   1) `git checkout v2-2-test && git pull`
   2) `./Breeze2` (or `python Breeze2` for Windows) -> Run latest Breeze from 
v2-2 branch` 
   
   Without having to reinstall anything (including when any dependencies change 
for Breeze between those versions)
   
   Any extra steps will add confusion and people (casual users especially) will 
run older Breeze versions with newer code and the other way round, which is 
exactly what I want to avoid.
   
   > This actually gives me a thought, since you feel it’s important to make 
the virtual environment (for Breeze) invisibal to the user. Maybe we should 
build Breeze entirely upon an existing task runner solution, instead of rolling 
our own infrastructure. [Nox](https://nox.thea.codes/en/stable/) has pretty 
much have virtual environment management and task invocation figured out—we can 
make Breeze a wrapper to `noxfile.py`, and just write subcommands as Nox tasks.
   
   I think nox mainly focuses on creating temporary venvs, and also I 
**really** do not want any dependencies to be able to run the above workflow. 
   
   I want precisely three things:
   
   * python3.7+
   * docker (TBD version)
   * docker-compose (which soon will be part of docker anyway) 
   
   See here: 
https://github.com/apache/airflow/pull/19867/files#diff-4d391b1ed30cbb2a992cddb4e9cb7d2f2f43a202bae3dd74d6dd44b0751c430dR116


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to