potiuk edited a comment on pull request #19867:
URL: https://github.com/apache/airflow/pull/19867#issuecomment-981804657
I have also added current stats of the languages used - I beleive sh should
be less than 300 lines of code (< 0.1% when we finish).
```
SLOC Directory SLOC-by-Language (Sorted)
144905 tests python=144761,xml=132,sh=12
130115 airflow python=127249,javascript=2827,sh=39
12052 docs javascript=8977,python=2931,sh=144
9073 scripts sh=7457,python=1616
6314 chart python=6218,sh=96
3665 top_dir sh=2896,python=769
3102 dev python=2938,sh=164
1723 kubernetes_tests python=1723
280 docker_tests python=280
140 metastore_browser python=140
109 clients sh=109
28 images sh=28
Totals grouped by language (dominant language first):
python: 288625 (92.65%)
javascript: 11804 (3.79%)
sh: 10945 (3.51%)
xml: 132 (0.04%)
```
I am pretty happy with what we have now as the first PR:
* automated bootstrapping of virtualenv installation for `Breeze2` command
* the bootstrapping is resistant to any missing dependencies. Currently it
only requires Python3.7+ to be installed locally and nothing else.
* the bootstrapping will automatically update the `Breeze2` venv whenever
necesseary (first time, and whenever setup.cfg changes, including checking out
branch).
* standardised package layout and using `pip install -e .` to install
virtualenb
* likely Windows support for bootstraping (to be tested on Windows)
* it's possible to add `Breeze2.exe` later on generated from `Breeze2` later
on if we want to make it really nicely work on Windows (currently `python
Breeze2` should be used to start Breeze on Windows)
I don't think we need to have another Breeze package in PyPI with this
setup, it's simply not needed as the `Breeze2` bootstraping should do the work
nicely for the user. The nice we have is that the standard package structure
will help with development (pip install -e .) even if we won't build and
publish the package in PyPI.
I already nicely integrated it as module in my IntelliJ without extra
"magic" using the bootstrapped virtualenv - should nicely work also on Windows.
@edithturn @Bowrna - maybe you could check it out and check it on your windows
machines to see how easy it is to bootstrap (also maybe you could try to
generate ./Breeze2.exe using `pyinstaller` and see if it woudl work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
