andrewgodwin commented on a change in pull request #19736:
URL: https://github.com/apache/airflow/pull/19736#discussion_r758707622
##########
File path: airflow/providers/databricks/hooks/databricks.py
##########
@@ -493,3 +504,120 @@ def __init__(self, token: str) -> None:
def __call__(self, r: PreparedRequest) -> PreparedRequest:
r.headers['Authorization'] = 'Bearer ' + self.token
return r
+
+
+class DatabricksAsyncHook(DatabricksHook):
+ """
+ Async version of the ``DatabricksHook``
+ Implements only necessary methods used further in Databricks Triggers.
+ """
+
+ def __init__(self, *args: Any, **kwargs: Any) -> None:
+ super().__init__(*args, **kwargs)
+
+ async def __aenter__(self):
+ self._session = aiohttp.ClientSession()
+ return self
+
+ async def __aexit__(self, *err):
+ await self._session.close()
+ self._session = None
+
+ async def _do_api_call(self, endpoint_info: Tuple[str, str], json: dict)
-> dict:
+ """
+ Utility function to perform an async API call with retries
+
+ :param endpoint_info: Tuple of method and endpoint
+ :type endpoint_info: tuple[string, string]
+ :param json: Parameters for this API call.
+ :type json: dict
+ :return: If the api call returns a OK status code,
+ this function returns the response in JSON. Otherwise, throw an
AirflowException.
+ :rtype: dict
+ """
+ method, endpoint = endpoint_info
+
+ self.databricks_conn = self.get_connection(self.databricks_conn_id)
Review comment:
The problem with turning async safety onto everything by default is that
you need something like the decorator to be in the middle of the call to do the
check - not sure we can reasonably override every Airflow API function without
some seriously dark magic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
