potiuk commented on a change in pull request #20019:
URL: https://github.com/apache/airflow/pull/20019#discussion_r762080010
##########
File path: airflow/models/param.py
##########
@@ -99,16 +99,17 @@ def has_value(self) -> bool:
return not isinstance(self.value, NoValueSentinel)
-class ParamsDict(dict):
+class ParamsDict(MutableMapping):
"""
Class to hold all params for dags or tasks. All the keys are strictly
string and values
are converted into Param's object if they are not already. This class is
to replace param's
dictionary implicitly and ideally not needed to be used directly.
"""
+ __slots__ = ['__dict__', 'supresss_exception']
Review comment:
```
Without a __dict__ variable, instances cannot be assigned new variables not
listed in the __slots__ definition. Attempts to assign to an unlisted variable
name raises AttributeError. If dynamic assignment of new variables is desired,
then add '__dict__' to the sequence of strings in the __slots__ declaration.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
