uranusjr commented on a change in pull request #20019:
URL: https://github.com/apache/airflow/pull/20019#discussion_r762427786
##########
File path: airflow/models/param.py
##########
@@ -99,16 +99,17 @@ def has_value(self) -> bool:
return not isinstance(self.value, NoValueSentinel)
-class ParamsDict(dict):
+class ParamsDict(MutableMapping):
Review comment:
```suggestion
class ParamsDict(MutableMapping[str, Any]):
```
This would allow annotating return values of `keys()` and `items()` (maybe
some more).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
