uranusjr commented on a change in pull request #20034:
URL: https://github.com/apache/airflow/pull/20034#discussion_r762426218
##########
File path: airflow/decorators/base.py
##########
@@ -101,22 +102,22 @@ class DecoratedOperator(BaseOperator):
:type kwargs_to_upstream: dict
"""
- template_fields = ('op_args', 'op_kwargs')
+ template_fields: Tuple[str, ...] = ('op_args', 'op_kwargs')
Review comment:
We need to unify typing for this, otherwise it’d cause subclass problems
when we annotate BaseOperator. I think `Sequence[str]` is probably better since
both tuple and list are used pretty extensively in the code base?
cc @ashb since you’re working on models (which includes BaseOperator)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
