uranusjr commented on a change in pull request #20034:
URL: https://github.com/apache/airflow/pull/20034#discussion_r762427547
##########
File path: airflow/decorators/base.py
##########
@@ -101,22 +102,22 @@ class DecoratedOperator(BaseOperator):
:type kwargs_to_upstream: dict
"""
- template_fields = ('op_args', 'op_kwargs')
+ template_fields: Tuple[str, ...] = ('op_args', 'op_kwargs')
template_fields_renderers = {"op_args": "py", "op_kwargs": "py"}
# since we won't mutate the arguments, we should just do the shallow copy
# there are some cases we can't deepcopy the objects (e.g protobuf).
- shallow_copy_attrs = ('python_callable',)
+ shallow_copy_attrs: Tuple[str, ...] = ('python_callable',)
Review comment:
Same for this
##########
File path: airflow/decorators/base.py
##########
@@ -101,22 +102,22 @@ class DecoratedOperator(BaseOperator):
:type kwargs_to_upstream: dict
"""
- template_fields = ('op_args', 'op_kwargs')
+ template_fields: Tuple[str, ...] = ('op_args', 'op_kwargs')
template_fields_renderers = {"op_args": "py", "op_kwargs": "py"}
# since we won't mutate the arguments, we should just do the shallow copy
# there are some cases we can't deepcopy the objects (e.g protobuf).
- shallow_copy_attrs = ('python_callable',)
+ shallow_copy_attrs: Tuple[str, ...] = ('python_callable',)
def __init__(
self,
*,
python_callable: Callable,
task_id: str,
- op_args: Tuple[Any],
+ op_args: List,
Review comment:
and this. Maybe even more. I get a feeling we should annotate
BaseOperator first before any other operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
