potiuk commented on pull request #19992:
URL: https://github.com/apache/airflow/pull/19992#issuecomment-986255818


   I think I found the combination that works (and @edithturn - it was not easy 
:). But it should nicely work now - both when the "Bootstrap" is run via 
`python Breeze2` and via "Bundled" Breeze2.exe. You can now try to build the 
.exe file and see if that works in your setup as well, and once it does, we 
might simply merge this one and maybe you could test it and add some 
instructions on how to build such a binary (and avold all the "Defender") 
problems as well. 
   
   I think it makes little sense to add the .exe to repo (it's quite big) and 
everyone should be able to generate one themselves if they need it - with 
simple one-liner (well maybe we can add a .bat script for that that will 
install pyinstaller, prepare the binary and move it to Airflow repo?) 
   
   I also noticed that whe you install Git on Windows, you can also choose to 
install "Git Bash" (based on MinGW). And I think this provides another nice 
option for Windows users - Git is another "implicit" prerequisite and we might 
simply ask the users to choose this option when installing Git. Then the 
`./Breeze2` command works exactly the same as on Linux/MacOS. 
   
   I think this all combined is "good enough" for the Windows users.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to