potiuk commented on pull request #19992:
URL: https://github.com/apache/airflow/pull/19992#issuecomment-986698026
> Did you move Breeze2.exe to another place to run it?
@edithturn - yep. I moved it to main folder of Airflow. This is where it
shoudl be eventually if someone wants to run it - because "dist" is a temporary
folder that gets overwritten.
@uranusjr - Actually I just wrote the ADR (I described all the decisions,
reasonsing and assumptions in this PR).
I REALLY do not want to use any 3rd-party tools here which would be
prerequisites for running Breeze (and they would not provide the same
experience regarding the 1. `git checkout`. 2. Run.
However while preparing the ADR and looking closely at the alternatives I
found out that `pipx` (which I understand is standard pypa project) also has
editable mode option whic works ALMOST the same way as the automated
bootstrapping of ours.
Ny proposal is to offer both alternatives to the users.
PIPX has two drawbacks:
* it will not automatically "upgrade when needed" which I think is an
important property - also for the kinds of "gitpodify" and "codespace"
environments where automated dependency management is really nice feature to
have.
* when you have more than one airflow working copy, only one of those can be
installed and used automatically at a time
For the next several months (at least - likely years) Breeze will be a
living project, changing together with airflow code, and this
is quite a limitation - people willl be switching to different branches
(2.3, 2.4 etc.) and there the Booststrapping script of ours has the benefit
that it will always use "local" version of Breeze, not the one "globally
installed".
So I think the best will be to leave our Breeze2 bootstrapping script for
"no requirements needed", "local" experience, but also have `pipx install -e
dev/breeze` as an alternative way of installing Breeze globally (especially if
the user has only one checked out Airflow version, that would be almost
equivalent to the Bootstrapping script of ours).
And seems that `pipx install -e dev\breeze` should work nicely and produce
the right Windows experience too (@edithturn can you please doube check it)?
I think having both options (our Bootstrapping script and pipx option) is
best of both worlds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
