uranusjr commented on a change in pull request #20019:
URL: https://github.com/apache/airflow/pull/20019#discussion_r763731225
##########
File path: tests/models/test_param.py
##########
@@ -167,18 +167,28 @@ def test_params_dict(self):
assert pd3.dump() == {'key': 'value'}
# Validate the ParamsDict
- pd.validate()
+ plain_dict = pd.validate()
+ assert type(plain_dict) == dict
pd2.validate()
pd3.validate()
# Update the ParamsDict
- with pytest.raises(ValueError):
+ with pytest.raises(ValueError, match=r'Invalid input for param key: 1
is not'):
Review comment:
Makes sense (especially since I _just_ fixed a PR yesterday because
MarkupSafe changed its exception message format).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
