mik-laj commented on issue #20032: URL: https://github.com/apache/airflow/issues/20032#issuecomment-988647949
@harishkrao Hi. I improved the tests yesterday and I think now it will be easy to write the missing test. See: https://github.com/apache/airflow/pull/20095 Now all you have to do is add a test case here. https://github.com/apache/airflow/blob/545ca59ba9a0b346cbbf28cc6958f9575e5e6b0b/tests/providers/snowflake/hooks/test_snowflake.py#L76-L95 To build a URL, we shouldn't use `string.format`. Instead of it, we should use `snowflake.sqlalchemy.URL`. See: https://github.com/snowflakedb/snowflake-sqlalchemy#connection-parameters The main problem with concatenation is the problem with handling of special characters due to the lack of URL-encoding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
