potiuk edited a comment on pull request #19860:
URL: https://github.com/apache/airflow/pull/19860#issuecomment-988887741


   > > Why do the query counts change? I don’t see any changes to the main code 
base.
   > 
   > They likely changed a long time ago, but those tests were quarantined so 
the counts didn't get updated.
   
   And to make things more difficult, Postgres in about 80% of those cases (not 
all) has one more call now for the "advisory lock" that Ash added in #19842 . 
Not every test reaches teh "advisory" lock grabbing so this is really 
hit-and-miss when you try to make some "logic" with the number (and it's only 
Postgres now so imagine the complexity of the condition). 
   
    I figured that adding margin will do what we wanted to achieve in the first 
place: see if we are not running "out-of-control" number of queries. We do not 
care about precise number, we care that we accidentally added a super 
inefficient code that adds 100s of DB calls. 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to