potiuk commented on a change in pull request #19914:
URL: https://github.com/apache/airflow/pull/19914#discussion_r765317510



##########
File path: airflow/utils/log/logging_mixin.py
##########
@@ -134,6 +136,56 @@ def isatty(self):
         """
         return False
 
+    def fileno(self) -> int:
+        pass
+
+    def read(self, n: int = ...) -> AnyStr:
+        pass
+
+    def readable(self) -> bool:
+        pass
+
+    def readline(self, limit: int = ...) -> AnyStr:
+        pass
+
+    def readlines(self, hint: int = ...) -> list:
+        pass
+
+    def seek(self, offset: int, whence: int = ...) -> int:
+        pass
+
+    def seekable(self) -> bool:
+        pass
+
+    def tell(self) -> int:
+        pass
+
+    def truncate(self, size: Optional[int] = ...) -> int:
+        pass
+
+    def writable(self) -> bool:
+        pass
+
+    def writelines(self, lines: Iterable[AnyStr]) -> None:
+        pass
+
+    def __next__(self) -> AnyStr:
+        pass
+
+    def __iter__(self) -> Iterator[AnyStr]:
+        pass
+
+    def __enter__(self) -> IO[AnyStr]:
+        pass
+
+    def __exit__(
+        self,
+        t: Optional[Type[BaseException]],
+        value: Optional[BaseException],
+        traceback: Optional[TracebackType],
+    ) -> Optional[bool]:
+        pass

Review comment:
       It's not logging mixin it's StreamLogWriter which is a concrete class 
which is used as redirect_output() or redirect_stderr() argument (and they 
expect to have a class that implements IO Generic. 
   
   Not sure if it can be simpler, but this is pretty straightforward.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to