potiuk commented on a change in pull request #19914:
URL: https://github.com/apache/airflow/pull/19914#discussion_r768211005
##########
File path: airflow/utils/task_group.py
##########
@@ -115,10 +115,10 @@ def __init__(
raise AirflowException("TaskGroup must have a parent_group
except for the root TaskGroup")
self.used_group_ids = self._parent_group.used_group_ids
- self._group_id = group_id
Review comment:
I refactored it slightly as it was pretty convoluted. We had three
group_ids: parmeter, self._group_id and self.group_id property all mixed
together in single methods. Extracted the method and it should be much clearer
now (there was one mistake - the `DuplicateTaskIdFound(f"group_id
'{self.group_id}' has already been added to the DAG")` should actually use
self._group_id.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
