subkanthi commented on a change in pull request #20190:
URL: https://github.com/apache/airflow/pull/20190#discussion_r767159816
##########
File path: airflow/providers/asana/hooks/asana.py
##########
@@ -23,7 +23,7 @@
from asana.error import NotFoundError
try:
- from functools import cached_property
+ from functools import cached_property # type: ignore
Review comment:
`if sys.version_info >= (3, 8):
from functools import cached_property
else:
from cached_property import cached_property`
The sys.version_info didnt fix the mypy error for me(Im trying in breeze),
should I be adding the # type: ignore to the sys.version_info code?
##########
File path:
airflow/providers/apache/cassandra/example_dags/example_cassandra_dag.py
##########
@@ -35,7 +35,7 @@
catchup=False,
tags=['example'],
) as dag:
- table_sensor = CassandraTableSensor(task_id="cassandra_table_sensor")
+ table_sensor = CassandraTableSensor(task_id="cassandra_table_sensor",
table="test")
Review comment:
Sorry, maybe im missing something, I dont see a default argument for
table, Im guessing this example_dag wasnt tested maybe.
` def __init__(
self, *, table: str, cassandra_conn_id: str =
CassandraHook.default_conn_name, **kwargs: Any
) -> None:
super().__init__(**kwargs)
self.cassandra_conn_id = cassandra_conn_id
self.table = table`
##########
File path:
airflow/providers/apache/cassandra/example_dags/example_cassandra_dag.py
##########
@@ -35,7 +35,7 @@
catchup=False,
tags=['example'],
) as dag:
- table_sensor = CassandraTableSensor(task_id="cassandra_table_sensor")
+ table_sensor = CassandraTableSensor(task_id="cassandra_table_sensor",
table="test")
Review comment:
@josh-fell Sorry, maybe im missing something, I dont see a default
argument for table, Im guessing this example_dag wasnt tested maybe.
` def __init__(
self, *, table: str, cassandra_conn_id: str =
CassandraHook.default_conn_name, **kwargs: Any
) -> None:
super().__init__(**kwargs)
self.cassandra_conn_id = cassandra_conn_id
self.table = table`
##########
File path:
airflow/providers/apache/cassandra/example_dags/example_cassandra_dag.py
##########
@@ -35,7 +35,7 @@
catchup=False,
tags=['example'],
) as dag:
- table_sensor = CassandraTableSensor(task_id="cassandra_table_sensor")
+ table_sensor = CassandraTableSensor(task_id="cassandra_table_sensor",
table="test")
Review comment:
Removed.
##########
File path: airflow/providers/asana/hooks/asana.py
##########
@@ -23,7 +23,7 @@
from asana.error import NotFoundError
try:
- from functools import cached_property
+ from functools import cached_property # type: ignore
Review comment:
Not sure if @potiuk also did the same here -
https://github.com/apache/airflow/pull/20223/files , because the
sys.version.info change doesnt fix the mypy errors.
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -53,6 +53,7 @@
create = AsanaCreateTaskOperator(
task_id="run_asana_create_task",
task_parameters={"notes": "Some notes about the task."},
+ conn_id='asana_default',
Review comment:
Removed.
##########
File path: airflow/providers/asana/example_dags/example_asana.py
##########
@@ -28,12 +28,12 @@
AsanaUpdateTaskOperator,
)
-ASANA_TASK_TO_UPDATE = os.environ.get("ASANA_TASK_TO_UPDATE")
-ASANA_TASK_TO_DELETE = os.environ.get("ASANA_TASK_TO_DELETE")
+ASANA_TASK_TO_UPDATE = os.getenv("ASANA_TASK_TO_UPDATE", "update_task")
+ASANA_TASK_TO_DELETE = os.getenv("ASANA_TASK_TO_DELETE", "delete_task")
Review comment:
Updated, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
