kazanzhy commented on a change in pull request #20190:
URL: https://github.com/apache/airflow/pull/20190#discussion_r767359908
##########
File path: airflow/providers/postgres/hooks/postgres.py
##########
@@ -211,7 +211,7 @@ def get_iam_token(self, conn: Connection) -> Tuple[str,
str, int]:
token = aws_hook.conn.generate_db_auth_token(conn.host, port,
conn.login)
return login, token, port
- def get_table_primary_key(self, table: str, schema: Optional[str] =
"public") -> List[str]:
+ def get_table_primary_key(self, table: str, schema: Optional[str] =
"public") -> Optional[List[str]]:
"""
Helper method that returns the table primary key
Review comment:
Hi. @subkanthi
Could you rename `table` to `schema` on lines 220:221?
I've also checked the Postgres operator and found this mistake, but after
that, I saw that such PR already exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]