Bowrna commented on pull request #20338: URL: https://github.com/apache/airflow/pull/20338#issuecomment-998531394
The following is the docker command when i tried running the Breeze (older version) in verbose mode. ``` docker build --build-arg PYTHON_BASE_IMAGE=ghcr.io/apache/airflow/main/python:3.7-slim-buster --build-arg AIRFLOW_VERSION=2.3.0.dev0 --build-arg AIRFLOW_BRANCH=main --build-arg AIRFLOW_EXTRAS=devel_ci --build-arg AIRFLOW_PRE_CACHED_PIP_PACKAGES=true --build-arg ADDITIONAL_AIRFLOW_EXTRAS= --build-arg ADDITIONAL_PYTHON_DEPS= --build-arg ADDITIONAL_DEV_APT_COMMAND= --build-arg ADDITIONAL_DEV_APT_DEPS= --build-arg ADDITIONAL_DEV_APT_ENV= --build-arg ADDITIONAL_RUNTIME_APT_COMMAND= --build-arg ADDITIONAL_RUNTIME_APT_DEPS= --build-arg ADDITIONAL_RUNTIME_APT_ENV= --build-arg UPGRADE_TO_NEWER_DEPENDENCIES=false --build-arg CONSTRAINTS_GITHUB_REPOSITORY=apache/airflow --build-arg AIRFLOW_CONSTRAINTS_REFERENCE=constraints-main --build-arg AIRFLOW_CONSTRAINTS=constraints-source-providers --build-arg AIRFLOW_IMAGE_REPOSITORY=https://github.com/apache/airflow --build-arg AIRFLOW_IMAGE_DATE_CREATED=2021-12-20T08:18:37Z --build-arg BUILD_ID=0 --build-arg COMMIT_SHA=5df4b6dadaff5f029b324fbc8f3bad b245a13673 --cache-from ghcr.io/apache/airflow/main/ci/python3.7 -t ghcr.io/apache/airflow/main/ci/python3.7 --target main . -f Dockerfile.ci ``` Here few build args like ADDITIONAL_PYTHON_DEPS, ADDITIONAL_DEV_APT_COMMAND are empty. But in the shell script below: https://github.com/apache/airflow/blob/85bedd03c33a1d6c6339e846558727bf20bc16f7/scripts/ci/libraries/_build_images.sh#L655-L669 Here we check if the params like DEV_APT_DEPS, DEV_APT_COMMAND, RUNTIME_APT_DEPS, RUNTIME_APT_COMMAND have non zero string length and then use it as build-arg. Is there any specific reason for doing this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
