uranusjr commented on a change in pull request #20470:
URL: https://github.com/apache/airflow/pull/20470#discussion_r774367251
##########
File path: airflow/dag_processing/processor.py
##########
@@ -574,7 +574,7 @@ def execute_callbacks(
if isinstance(request, TaskCallbackRequest):
self._execute_task_callbacks(dagbag, request)
elif isinstance(request, SlaCallbackRequest):
- self.manage_slas(dagbag.dags.get(request.dag_id))
+ self.manage_slas(dagbag.dags[request.dag_id])
Review comment:
SLA doesn’t make sense without a DAG, so this is better IMO. It’s good
to fail here if things go wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
