josh-fell commented on a change in pull request #20470:
URL: https://github.com/apache/airflow/pull/20470#discussion_r775328715
##########
File path: airflow/models/taskinstance.py
##########
@@ -1764,7 +1764,7 @@ def handle_failure(
@provide_session
def handle_failure_with_callback(
self,
- error: Union[str, Exception],
+ error: Optional[Union[str, Exception]] = None,
Review comment:
Both `self.handle_failure()` and `self._run_finished_callback()`
functions called in this method are typed to have the `error` arg has optional.
From what I can tell `self.handle_failure()` _should_ always have an `error`
value but `self._run_finished_callback()` may not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
