potiuk commented on a change in pull request #20482:
URL: https://github.com/apache/airflow/pull/20482#discussion_r774503299
##########
File path: airflow/utils/context.pyi
##########
@@ -48,7 +48,7 @@ class VariableAccessor:
class ConnectionAccessor:
def get(self, key: str, default_conn: Any = None) -> Any: ...
-class Context(TypedDict, total=False):
+class Context(TypedDict):
Review comment:
Why would you need that ? This means that we can omit any of the fields
but IMHO that would be great if we can make assumption that all fields are
present in Context - so that whenever we need, we just add empty/default
values for them whenever we find it necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
