uranusjr commented on a change in pull request #20482:
URL: https://github.com/apache/airflow/pull/20482#discussion_r774779237
##########
File path: airflow/utils/context.pyi
##########
@@ -48,7 +48,7 @@ class VariableAccessor:
class ConnectionAccessor:
def get(self, key: str, default_conn: Any = None) -> Any: ...
-class Context(TypedDict, total=False):
+class Context(TypedDict):
Review comment:
This shouldn’t really matter because totality is checked on
initialisation, and we don’t actually instantiate the context object directly,
only force-cast a dict into one. And I chose `total=False` because it is
arguably more correct semantically—the context does not always contain all the
keys listed in this fake TypedDict.
What is the reason behind this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
