dstandish commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r774722220
##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,19 @@
Changelog
---------
+3.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Simplify KubernetesPodOperator (#19572)``
+
+.. warning:: Many methods in :class:`~.KubernetesPodOperator` and
class:`~.PodLauncher` have been renamed.
+ If you have subclassed :class:`~.KubernetesPodOperator` will need to
update your subclass to reflect
+ the new structure. Additionally ``PodStatus`` enum has been renamed to
``PodPhase``.
Review comment:
thinking about it more.... i am not sure we should go the metaclass
route
being able to remove / rename old methods is one of the benefits of using
semver. we can do so and people (if they know what semver means, and granted
many probably don't) will have fair warning about what is coming.
do we really want to establish the convention that any time you remove or
rename a method in a major release, you must add a metaclass and ban the old
methods? this ads a bit of a complexity burden. and when trying to understand
the havior of a class (and as a user, i think digging into the operator code
is common), it's yet another thing to have to look into. and more noise when
finding etc.
i think it's a noble idea, but i am skeptical that it's really worth these
tradeoffs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
