dstandish commented on a change in pull request #19572:
URL: https://github.com/apache/airflow/pull/19572#discussion_r776028613



##########
File path: airflow/providers/cncf/kubernetes/CHANGELOG.rst
##########
@@ -19,6 +19,19 @@
 Changelog
 ---------
 
+3.0.0
+.....
+
+Breaking changes
+~~~~~~~~~~~~~~~~
+
+* ``Simplify KubernetesPodOperator (#19572)``
+
+.. warning:: Many methods in :class:`~.KubernetesPodOperator` and 
class:`~.PodLauncher` have been renamed.
+    If you have subclassed :class:`~.KubernetesPodOperator` will need to 
update your subclass to reflect
+    the new structure. Additionally ``PodStatus`` enum has been renamed to 
``PodPhase``.

Review comment:
       alright gentlemen, i have added some notes giving an overview of the 
motivations of the change, what changed at a high level, and at a high level 
how it works now.
   
   It may be more detail than appropriate in a change log?  But it sounded like 
we wanted to err on the side of giving users more information to help  them 
digest the changes.  If you have suggestions, e.g. if you think it should be 
rellocated or truncated in some ways lemme know.
   
   I also  bullet point the method name changes (or most of them anyway).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to