uranusjr commented on a change in pull request #20482:
URL: https://github.com/apache/airflow/pull/20482#discussion_r774781268
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -82,13 +82,15 @@ def _render_filename(self, ti: "TaskInstance", try_number:
int) -> str:
context = Context(ti=ti,
ts=ti.get_dagrun().logical_date.isoformat())
Review comment:
But removing `total=False` _shouldn’t_ work here—it should be the other
way around because this requires non-totality! We should keep `total=False` and
find another solution.
https://www.python.org/dev/peps/pep-0589/#totality
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
