josh-fell commented on pull request #20540:
URL: https://github.com/apache/airflow/pull/20540#issuecomment-1002259262
> I like it... BUT... must we consider this a "breaking" change?
For some historical context on this and moving the `get_connection()` call
in and out of `__init__()` if it helps assist in a decision:
- v2.0.1
- `get_connection()` call exists in `__init__()`
- `host` is not an instance attr
- v2.0.2
- `get_connection()` removed `__init__()`
- `host` is not an instance attr
- v2.1.0
- `get_connection()` was put back into `__init__()` via #19835 which then
added `host` as an instance attr
- `get_connection()` was then removed again `__init__()` via #20180 which
kept `host` as an instance attr
- Ultimately, end state was `get_connection()` removed from `__init__()`
but `host` remained an instance attr
- Since the last provider release:
- `get_connection()` moved back into `__init__()` to address Mypy
reenablement errors in #20265
- `get_connection()` called as part of a cached prop in #20526
- `host` remained untouched until this PR
Quite the adventure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
