dstandish edited a comment on pull request #20540: URL: https://github.com/apache/airflow/pull/20540#issuecomment-1002260448
> > I like it... BUT... must we consider this a "breaking" change? > > Why ? Because `host` will no longer be set after `__init__` in last release it seems instance attr `host` was set in `__init__` this among the most marginal of changes we should consider "breaking" but if we want to be strict it probably is right to consider it so. in this case the solution should probably be to make it a cached property. but @potiuk if you think we can just chop the attr that would be best from code perspective. based on @josh-fell's analyis it seems it was only an instance attr for one release (since v2.1.0) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
