dstandish opened a new pull request #20578:
URL: https://github.com/apache/airflow/pull/20578
What I've done here is entirely defer to the KubernetesHook with regard to
using airflow conn id vs the three other parameters.
I _think_ this should work.
But one thing I wonder about are these airflow conf settings in
`get_kube_client`:
```python
if not in_cluster:
if cluster_context is None:
cluster_context = conf.get('kubernetes', 'cluster_context',
fallback=None)
if config_file is None:
config_file = conf.get('kubernetes', 'config_file',
fallback=None)
if conf.getboolean('kubernetes', 'enable_tcp_keepalive'):
_enable_tcp_keepalive()
if not conf.getboolean('kubernetes', 'verify_ssl'):
_disable_verify_ssl()
client_conf = _get_kube_config(in_cluster, cluster_context, config_file)
return _get_client_with_patched_configuration(client_conf)
```
It doesn't seem that KubernetesHook lookss at these settings. Do you think
we need to implement either / or logic here? That is, only use K8s hook if an
airflow conn id is provided? And otherwise, continue to use `get_kube_client`?
Thanks
cc @jedcunningham
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
